Remove legacy RCTTimingModule (#57037)#57037
Open
christophpurrer wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107201906. |
cortinico
approved these changes
Jun 2, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D107201906
branch
from
b258084 to
184a83d
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 2, 2026
Summary: Wires `RCTTiming` (iOS CoreModule for `setTimeout`/`setInterval`/idle callbacks) to the existing TurboModule spec at `packages/react-native/src/private/specs_DEPRECATED/modules/NativeTiming.js`. `RCTTiming` was the only remaining `legacy = True` entry in `React/CoreModules/BUCK`. The existing `RCT_EXPORT_METHOD` signatures already match the spec exactly, so this is a registration/wiring change only. Changes: - `RCTTiming.mm`: declare `<NativeTimingSpec>` conformance in a private interface and add `getTurboModule:` returning `NativeTimingSpecJSI`, mirroring the pattern used by `RCTAppState`. - `React/CoreModules/BUCK`: drop `legacy = True` from the `Timing` entry of `react_module_plugin_providers`. No public header changes — the bridgeless path (`ObjCTimerRegistry`) continues to instantiate `RCTTiming` via `initWithDelegate:` and the `RCTTimingDelegate` protocol. No CocoaPods / Swift Package changes are needed: `React-CoreModules.podspec` globs all `CoreModules/*.mm` and `FBReactNativeSpec` codegens `NativeTimingSpecJSI` from the existing JS spec. ## Changelog: [IOS][Fixed]Convert RCTTiming to TurboModule Differential Revision: D107201906
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer
force-pushed
the
export-D107201906
branch
2 times, most recently
from
f849c2f to
c625fe7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer
force-pushed
the
export-D107201906
branch
from
c625fe7 to
3fc1d3c
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer
force-pushed
the
export-D107201906
branch
from
3fc1d3c to
dac9bf7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[IOS][Fixed] Remove legacy RCTTimingModule
Differential Revision: D107201906