Update Node.js version and checkout action versions#705
Closed
gracepark wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the release publishing workflow to align with OIDC migration by pinning GitHub Actions dependencies and moving the publish job to a newer Node.js runtime.
Changes:
- Pin
actions/checkoutandactions/setup-nodeto specific commit SHAs (with version comments). - Bump the publish workflow’s Node.js version from 22 to 24.
- Remove use of the npm auth token environment variable from the publish step.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish.yml | Pins action versions, bumps Node.js for publishing, and adjusts publish auth flow for OIDC/provenance. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
| @@ -24,5 +24,3 @@ jobs: | |||
| env: | |||
| TAG_NAME: ${{ github.event.release.tag_name }} | |||
| - run: npm whoami; npm --ignore-scripts publish --provenance | |||
| - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 24 |
Contributor
|
@gracepark sorry for the double work here, I just merged #704 which tackled these same bits, plus some other supply chain improvements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309#issuecomment-4608163612
OIDC migration