Narrow host-path prefix API surface#4052
Conversation
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
Coverage comparison generated by |
Smoke Test: Claude Engine
Result: PASS
|
🔥 Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Overall: PARTIAL — BYOK inference path confirmed working; pre-step smoke data was not injected into the prompt template. PR author:
|
🔬 Smoke Test Results
PR: "Narrow host-path API surface" — author: Overall: PARTIAL — MCP confirmed working; pre-step outputs were not injected into task body.
|
There was a problem hiding this comment.
Pull request overview
Narrows the host-path-prefix.ts API surface by removing the translateBindMountHostPath export and updating the lone test that referenced it to use the public applyHostPathPrefixToVolumes helper instead.
Changes:
- Make
translateBindMountHostPathmodule-private insrc/services/host-path-prefix.ts. - Update
agent-volumes-mounts.test.tsto assert/tmpstaging fallback behavior viaapplyHostPathPrefixToVolumes.
Show a summary per file
| File | Description |
|---|---|
| src/services/host-path-prefix.ts | Drops the export keyword on translateBindMountHostPath. |
| src/services/agent-volumes-mounts.test.ts | Switches the /etc/passwd//etc/group preservation test to the public helper. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
Chroot Runtime Version Comparison
Result: ❌ Not all versions match — Python and Node.js versions differ between host and chroot environments.
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL —
|
Gemini Smoke Test: PASS\n- MCP: ✅\n - Deduplicate server test HTTPS_PROXY/module-reset bootstrap across split api-proxy tests\n - [docs] Document AWF_DIND env var and ARC/DinD sibling-socket auto-detection\n- Connectivity: ✅\n- File Writing: ✅\n- Bash: ✅Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
|
Reviewed merged PRs:
Checks: GitHub ✅ Playwright ✅ File ✅ Discussion ✅ Build ❌
|
translateBindMountHostPathwas exported fromsrc/services/host-path-prefix.tseven though production code only uses it internally throughapplyHostPathPrefixToVolumes. This change removes that unnecessary public symbol and keeps coverage on the public volume-rewrite entrypoint.API surface
translateBindMountHostPathexport fromsrc/services/host-path-prefix.tsapplyHostPathPrefixToVolumesas the public interface for bind-mount source translationTest coverage
src/services/agent-volumes-mounts.test.tsto assert the shared/tmpfallback behavior viaapplyHostPathPrefixToVolumesResult