Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #
This pull request adds a new
"hide"collapse mode toion-headerandion-footer, allowing the them to slide and fade out on scroll down and reappear on scroll up."hide"mode is supported across all themes (ios,md, andionic).What is the new behavior?
"hide"as a valid value for thecollapseprop onion-footer, updating the API and documentation to reflect that it works across all themes and behaves likeion-header[collapse="hide"][1] [2]."hide"interaction infooter.tsx, including setup/teardown logic, theme checks, and state management to ensure smooth transitions and prevent redundant event listener registration [1] [2] [3] [4].Styling and Animation
footer.scssandcontent.scss, handling transitions, transforms, and layout adjustments for when the footer is hidden or shown, and coordinating with content scroll [1] [2].Utilities
createFooterHideInteractionutility infooter.utils.tsto encapsulate the logic for managing the hide/show state and related CSS classes/variables, leveraging a shared on-scroll interaction utility [1] [2].Testing
API Updates
core/api.txtto document the new"hide"option for bothion-footerandion-header, ensuring API documentation is accurate [1] [2].Does this introduce a breaking change?