Refactor and standardize argparse-related naming and metadata#1670
Open
kmvanbrunt wants to merge 11 commits into
Open
Refactor and standardize argparse-related naming and metadata#1670kmvanbrunt wants to merge 11 commits into
kmvanbrunt wants to merge 11 commits into
Conversation
- Consistently use full words COMMAND and SUBCOMMAND over abbreviations - Rename cmd2_subcmd_handler to cmd2_subcommand_func for consistency - Consolidate command metadata into ApCommandSpec dataclass - Simplify subcommand examples by using required=True for subparsers
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1670 +/- ##
==========================================
+ Coverage 99.50% 99.54% +0.03%
==========================================
Files 23 23
Lines 5682 5675 -7
==========================================
- Hits 5654 5649 -5
+ Misses 28 26 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
kmvanbrunt
force-pushed
the
ap_command_spec
branch
from
1dda279 to
44fd9e8
Compare
tleonhardt
previously approved these changes
May 28, 2026
This is to match what it's called in the Namespace when using with_argparser.
…rser(). Renamed set_default_ap_completer_type() to set_default_argparse_completer(). Renamed Cmd2ArgumentParser.ap_completer_type to completer_class.
kmvanbrunt
changed the title
kmvanbrunt
changed the title
…ENT_PARSER. Added test for set_default_argument_parser().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.