Skip to content

gh-105812: Make use of the Sphinx deco role in documentation#139598

Merged
JelleZijlstra merged 4 commits into
python:mainfrom
Viicos:deco-role-pt1
Jun 3, 2026
Merged

gh-105812: Make use of the Sphinx deco role in documentation#139598
JelleZijlstra merged 4 commits into
python:mainfrom
Viicos:deco-role-pt1

Conversation

@Viicos
Copy link
Copy Markdown
Contributor

@Viicos Viicos commented Oct 5, 2025

For the following decorators: classmethod, staticmethod, property, ABC decorators, enum decorators, functools.lru_cache, functools.cache.

Note that depending on the context, I left references as :func: or :class:, for instance when it is reference as "the <...> object/function/descriptor".


📚 Documentation preview 📚: https://cpython-previews--139598.org.readthedocs.build/

… part 1

For the following decorators: `classmethod`, `staticmethod`,
`property`, ABC decorators, enum decorators, `functools.lru_cache`,
`functools.cache`.
@AA-Turner
Copy link
Copy Markdown
Member

If this is 'part 1', what are the expected follow-up changes?

A

@Viicos
Copy link
Copy Markdown
Contributor Author

Viicos commented Oct 5, 2025

If this is 'part 1', what are the expected follow-up changes?

I'll comment on the original issue the remaining ones. Let me know if this is fine to tackle everything in a single PR.

@AA-Turner
Copy link
Copy Markdown
Member

Let me know if this is fine to tackle everything in a single PR.

I'd prefer one PR to review, as long as the diff stays reasonable.

A

@rhettinger rhettinger removed their request for review October 6, 2025 07:08
@Viicos
Copy link
Copy Markdown
Contributor Author

Viicos commented Oct 25, 2025

@AA-Turner I migrated the remaining decorators.

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 30, 2026
Comment thread Doc/whatsnew/2.5.rst Outdated
Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but this now has merge conflicts.

@Viicos Viicos requested a review from ZeroIntensity as a code owner June 3, 2026 13:05
@Viicos Viicos changed the title gh-105812: Make use of the Sphinx deco role in documentation, part 1 gh-105812: Make use of the Sphinx deco role in documentation Jun 3, 2026
@Viicos
Copy link
Copy Markdown
Contributor Author

Viicos commented Jun 3, 2026

Merged main to resolve conflicts.

@JelleZijlstra JelleZijlstra enabled auto-merge (squash) June 3, 2026 13:09
@JelleZijlstra JelleZijlstra merged commit deb33ec into python:main Jun 3, 2026
29 of 30 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants