-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
gh-150449: Fix sqlite3.Blob crash with negative-step slices #150450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ever0de
wants to merge
13
commits into
python:main
Choose a base branch
from
ever0de:gh-150449-fix-sqlite-blob-negative-step-slice
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
af0eb65
gh-150449: Fix sqlite3.Blob crash with negative-step slices
ever0de 85312b4
gh-150449: validate slice assignment size even for empty slices
ever0de c0c2018
gh-150449: add tests for negative-step slices with start <= stop
ever0de 83d3a3c
Fix PEP 7 line-length violations in blob.c (ass_subscript_slice)
ever0de f7c9f53
gh-150449: Address review: docs, tests, and rename write_offset
ever0de 5087b42
gh-150449: Fix versionchanged version: use 'next' not '3.16'
ever0de d774ab7
gh-150449: Fix wording in NEWS and whatsnew: 'crash' → 'raise SystemE…
ever0de 5bf02de
gh-150449: Remove redundant issue references from test comments
ever0de c311c8e
Merge remote-tracking branch 'upstream/main' into gh-150449-fix-sqlit…
ever0de d4b4b43
gh-150449: Fix missing blank line after xml section in whatsnew
ever0de 0936d6b
gh-150449: Rename read_length to write_length in ass_subscript_slice
ever0de 5f2f916
gh-150449: Move empty-slice validation fix to dedicated PR for gh-150913
ever0de d47abf8
Merge remote-tracking branch 'upstream/main' into gh-150449-fix-sqlit…
ever0de File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2026-05-26-15-53-50.gh-issue-150449.GfDWxl.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| :class:`sqlite3.Blob` now supports negative-step slices for reading and | ||
| writing (e.g. ``blob[9:0:-2]``). Previously, such slices would raise | ||
| :exc:`SystemError` or :exc:`ValueError`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOC why all those casts? start and atep are already ssize values, and then we recast cur to ssize_t. Why not having ssize_t everywhere? there should not be any issues with signed comparisons as both operands are signed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSIZE_MAX + SSIZE_MAX = integer overflow.
The code is more complicated with signed integers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right. If we can add a test case for that it would be good but if it is too complex to do it (by mocking some stuff), let's forget it. I am keeping the comment unresolved so that future readers will remember
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth adding an inline comment here to explain why
size_tis used instead ofPy_ssize_t? Something like: