feat: add --aggregate-parameter-runs to combine parameter scan stats (fixes #778)#893
Open
leno23 wants to merge 1 commit into
Open
feat: add --aggregate-parameter-runs to combine parameter scan stats (fixes #778)#893leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
…ixes sharkdp#778) When benchmarking one sample per parameter value, pool all timed runs into a single mean/stddev summary instead of reporting separate benchmarks for each substituted command. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #778.
Adds
--aggregate-parameter-runsfor--parameter-scan/--parameter-listworkloads where each parameter value should contribute one sample to the same benchmark (e.g. transferring different files once each).Instead of reporting N separate benchmarks, hyperfine pools all timed runs and prints/exports a single mean ± σ summary for the shared command template.
Note: this is distinct from #830 (combining results from separate hyperfine invocations), which would need a different mechanism.
Changes
Options::aggregate_parameter_runsand CLI flagCommands::supports_parameter_aggregation()BenchmarkResults withmerge_parameter_benchmark_results()--referenceExample
hyperfine --runs 1 --aggregate-parameter-runs \ --parameter-scan index 1 20 'transfer_data file{index}.dat'Test plan
cargo test scheduler_aggregate_parameter_runscargo testMade with Cursor