feat(tables): workflow version selection (live/deployed) and not-found/no-output badges#4889
Conversation
…d/no-output badges
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Grid UX: workflow columns whose source block is gone show a Minor polish: multi-select left edge drawn in the sticky checkbox column; removed required asterisk on workflow inputs label. Reviewed by Cursor Bugbot for commit b85f9f7. Bugbot is set up for automated code reviews on this repo. Configure here. |
![cursor[bot]](https://github.com/_gh/avatars/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bc1a0dd. Configure here.
Greptile SummaryThis PR adds three UI features to the Sim tables: a per-group Workflow version segmented toggle (Live / Deployed) in the sidebar advanced section, a "Not found" badge in column headers when the source block no longer exists, and a "No output" cell badge when a workflow run completes but produces no value for a cell (distinct from a never-run blank). The deployment mode is plumbed through the full stack — contract schemas, API route, service layer, and background executor — with the executor correctly reading
Confidence Score: 5/5Safe to merge — the deployment mode is correctly threaded through all layers with no silent fallbacks, previous review findings are fully addressed, and the changes are well-scoped to the tables feature. All three features (deployment mode toggle, 'Not found' badge, 'No output' badge) are correctly implemented end-to-end. The cascade stale-mode bug from the prior review is fixed by reading deploymentMode from the live group per iteration. The error surfacing fix uses the actual thrown error message. The 'Not found' badge is correctly gated to live-mode groups and deferred until workflow state finishes loading. The CSS border fix is logically sound. No functional defects were found. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Sidebar: Save WorkflowGroup] -->|deploymentMode included| B[PATCH /api/table/groups]
B --> C[updateWorkflowGroup service]
C --> D[WorkflowGroup stored in schema JSON]
E[Background: runRowCascadeLoop] --> F{Fresh group from DB}
F -->|group.deploymentMode| G[runWorkflowAndWriteTerminal]
G --> H{deploymentMode?}
H -->|'deployed'| I[loadDeployedWorkflowState]
H -->|'live' or undefined| J[loadWorkflowFromNormalizedTables]
I -->|error| K[writeState: error with real message]
I -->|success| L[executeWorkflow useDraftState=false]
J --> M[executeWorkflow useDraftState=true]
L --> N[buildOutputsByBlockId]
M --> N
N -->|value present| O[Cell: value rendered]
N -->|value empty| P[writeState: completed]
P --> Q[resolveCellRender]
Q -->|isEnrichmentOutput| R[Badge: Not found]
Q -->|workflow column| S[Badge: No output]
T[use-table.ts columnSourceInfo] -->|isLiveMode && blocks loaded && blockId missing| U[blockMissing=true]
U --> V[Column header: Not found badge]
Reviews (2): Last reviewed commit: "fix(tables): render selection left edge ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://github.com/_gh/avatars/in/867647?s=60&v=4){kind=small}
…it cannot be cut off
…p not-found for deployed groups
|
Addressed review feedback in
tsc + biome + @greptile review |
…ship deploymentMode
# Conflicts: # apps/sim/lib/copilot/tools/server/table/user-table.ts
2 participants
Summary
useDraftStatein cell execution; aDeployedgroup with no active deployment fails the cell with a clear message.Type of Change
Testing
Tested manually.
bun run check:api-validation:strictpasses;bun run lint:checkclean on all touched files (pre-existing unrelated lint findings left untouched);tsc --noEmitclean.Checklist